Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimizations for binning #283

Merged
merged 7 commits into from
Nov 1, 2024
Merged

Performance optimizations for binning #283

merged 7 commits into from
Nov 1, 2024

Conversation

e-n-f
Copy link
Collaborator

@e-n-f e-n-f commented Oct 18, 2024

Does not try to bin geometrically if --bin-by-id-list is specified, only by ID.

Keeps attribute values in mvt_value format when accumulating in overzoom, rather than converting back and forth to serial_val.

@e-n-f e-n-f marked this pull request as ready for review November 1, 2024 16:58
@e-n-f e-n-f requested review from ChrisLoer and removed request for ChrisLoer November 1, 2024 21:55
Copy link

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested in Felt.

@e-n-f e-n-f merged commit b3b89e1 into main Nov 1, 2024
4 checks passed
@e-n-f e-n-f deleted the bin-optimize branch November 1, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants